Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pomegranate: 0.13.5 -> 0.14.8 #175336

Merged
merged 1 commit into from
May 29, 2022

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 29, 2022

Description of changes

ZHF: #172160

Builds on darwin where we were previously having test failures.

cnvkit already broken: https://hydra.nixos.org/eval/1764251?filter=cnvkit&compare=1764191&full=

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented May 29, 2022

@ofborg build python39Packages.pomegranate python310Packages.pomegranate

@fabaff
Copy link
Member

fabaff commented May 29, 2022

Result of nixpkgs-review pr 175336 run on x86_64-linux 1

2 packages failed to build:
  • python310Packages.cnvkit
  • python39Packages.cnvkit
2 packages built:
  • python310Packages.pomegranate
  • python39Packages.pomegranate

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@github-actions
Copy link
Contributor

Successfully created backport PR #175371 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants