Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rss-glx: fix build #175287

Merged
merged 1 commit into from
Jun 23, 2022
Merged

rss-glx: fix build #175287

merged 1 commit into from
Jun 23, 2022

Conversation

azahi
Copy link
Member

@azahi azahi commented May 29, 2022

Description of changes

Fix build https://hydra.nixos.org/build/178217710

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@azahi
Copy link
Member Author

azahi commented May 29, 2022

Result of nixpkgs-review pr 175287 run on x86_64-linux 1

1 package built:
  • rss-glx

@risicle
Copy link
Contributor

risicle commented May 29, 2022

On nixos x86_64:

builder for '/nix/store/qlygmh842pwwv6ix7pykgs2hxm0kj879-rss-glx-0.9.1.drv' failed with exit code 2; last 10 log lines:
  /nix/store/2b99rpx8zwdjjqkrvk7kqgn9mxhiidjy-binutils-2.38/bin/ld: /nix/store/8yphmqqn2wpp6aq3iid9i1bkx312lgqj-libheif-1.12.0/lib/libheif.so.1: undefined reference to `std::__exception_ptr::exception_ptr::_M_release()@CXXABI_1.3.13'
  /nix/store/2b99rpx8zwdjjqkrvk7kqgn9mxhiidjy-binutils-2.38/bin/ld: /nix/store/8yphmqqn2wpp6aq3iid9i1bkx312lgqj-libheif-1.12.0/lib/libheif.so.1: undefined reference to `std::__exception_ptr::exception_ptr::_M_addref()@CXXABI_1.3.13'
  collect2: error: ld returned 1 exit status
  make[3]: *** [Makefile:578: drempels] Error 1
  make[3]: Leaving directory '/build/rss-glx_0.9.1/src'
  make[2]: *** [Makefile:1037: all-recursive] Error 1
  make[2]: Leaving directory '/build/rss-glx_0.9.1/src'
  make[1]: *** [Makefile:312: all-recursive] Error 1
  make[1]: Leaving directory '/build/rss-glx_0.9.1'
  make: *** [Makefile:241: all] Error 2

@azahi
Copy link
Member Author

azahi commented May 29, 2022

Well, that's weird. It builds fine for me.

@azahi
Copy link
Member Author

azahi commented May 29, 2022

Result of nixpkgs-review pr 175287 run on x86_64-linux 1

1 package failed to build:
  • rss-glx

@azahi
Copy link
Member Author

azahi commented May 29, 2022

Wow, that's very strange. I'll look into this.

@azahi
Copy link
Member Author

azahi commented Jun 5, 2022

The issue was in:

- rss-glx = callPackage ../misc/screensavers/rss-glx { stdenv = gcc10StdenvCompat; };
+ rss-glx = callPackage ../misc/screensavers/rss-glx { };

@risicle All should work now.

@azahi azahi requested a review from risicle June 5, 2022 19:13
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/937

@Lassulus
Copy link
Member

Result of nixpkgs-review pr 175287 run on x86_64-linux 1

1 package built:
  • rss-glx

@Lassulus Lassulus merged commit 8c2b958 into NixOS:master Jun 23, 2022
@github-actions
Copy link
Contributor

Successfully created backport PR #178799 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants