Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mars: fix build #174992

Merged
merged 1 commit into from
May 28, 2022
Merged

mars: fix build #174992

merged 1 commit into from
May 28, 2022

Conversation

azahi
Copy link
Member

@azahi azahi commented May 27, 2022

Description of changes

Bumps the revision and fixes https://hydra.nixos.org/build/178082390

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@azahi
Copy link
Member Author

azahi commented May 27, 2022

Not sure if should bump package version or not because the CMakeLists.txt file says that it's 0.7.5.

@azahi
Copy link
Member Author

azahi commented May 27, 2022

Result of nixpkgs-review pr 174992 run on x86_64-linux 1

1 package built:
  • mars

@ofborg ofborg bot requested a review from astsmtl May 27, 2022 19:12
@risicle
Copy link
Contributor

risicle commented May 28, 2022

If this isn't an official release revision, it should possibly be given an unstable-YYYY-MM-DD version.

@azahi
mars: fix build
f35a5e2 
Bumps the revision and fixes https://hydra.nixos.org/build/178082390
Mark the version as "unstable" because the latest official version does
not build and there are no new releases.
@azahi
Copy link
Member Author

azahi commented May 28, 2022

I've marked it with the date of the latest upstream commit.

@risicle
Copy link
Contributor

risicle commented May 28, 2022

Perfect. Though someone nitpicky might ask you to use dashes instead of dots for the date.

@balsoft balsoft merged commit 535031c into NixOS:master May 28, 2022
@github-actions github-actions bot mentioned this pull request May 28, 2022
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #175124 for release-22.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astsmtl astsmtl Awaiting requested review from astsmtl

Assignees
No one assigned
Labels
0.kind: build failure 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azahi @risicle @balsoft