-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "xorg.xorgserver: 1.20.13 -> 21.1.3" #174140
Conversation
This reverts commit 3312352. Fixes NixOS#170856: issues of some users.
According to testing on the issue, reverting the driver bumps from PR #153994 isn't needed to fix the issues. (There are no newer releases for -ati and -nouveau.) However, there's a newer release of xorg-server-1.20.14, but the affected people haven't tested it (yet), so I can't be confident that it didn't backport the regression. (There is some modesetting change.) You can try https://github.com/vcunat/nixpkgs/commits/p/xorg-server_bump |
We've been using 1.20.13 for a very long time and I don't recall people reporting problems, so I'd hope it would be OK even without doing more testing beforehand. |
Can confirm reverting to xorg-server-1.20.14 is solving the issue for me. |
With the amounts of rebuilds we should target staging-next at least. |
I assume .14 will be preferable to .13, so I added that here now, but more testing would still be nice. |
I just switched to this branch, and I can confirm that this still works, whereas the latest |
I think we have enough feedback to stage this at least for unstable. |
Successfully created backport PR #175320 for |
@@ -218,4 +218,4 @@ mirror://xorg/individual/util/lndir-1.0.3.tar.bz2 | |||
mirror://xorg/individual/util/makedepend-1.0.6.tar.bz2 | |||
mirror://xorg/individual/util/util-macros-1.19.3.tar.bz2 | |||
mirror://xorg/individual/util/xorg-cf-files-1.0.7.tar.bz2 | |||
mirror://xorg/individual/xserver/xorg-server-21.1.3.tar.xz | |||
mirror://xorg/individual/xserver/xorg-server-1.20.13.tar.xz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forgot to change this to .14, fix in #199912
Diff: https://github.com/freedesktop/xorg-xserver/compare/xorg-server-1.20.14...xorg-server-21.1.7 This reverts the revert on NixOS#174140
This reverts commit 3312352.
Fixes #170856: issues of some users.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes