Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ber-metaocaml: make useX11 be a parameter rather than a let-binding #173814

Merged
merged 1 commit into from May 24, 2022
Merged

ber-metaocaml: make useX11 be a parameter rather than a let-binding #173814

merged 1 commit into from May 24, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2022

Description of changes

This allows callers to choose the value of useX11 themselves, for
example in config.nix.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This allows callers to choose the value of useX11 themselves, for
example in config.nix.
@vbgl vbgl merged commit 4b8488f into NixOS:master May 24, 2022
@ghost ghost deleted the pr/ber-metaocaml/make-useX11-a-parameter branch May 24, 2022 22:04
@ghost ghost restored the pr/ber-metaocaml/make-useX11-a-parameter branch May 24, 2022 22:04
@ghost ghost deleted the pr/ber-metaocaml/make-useX11-a-parameter branch May 24, 2022 22:04
@ghost ghost restored the pr/ber-metaocaml/make-useX11-a-parameter branch May 24, 2022 22:04
@ghost ghost deleted the pr/ber-metaocaml/make-useX11-a-parameter branch May 24, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant