Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: update stackage and hackage #173800

Merged
merged 29 commits into from
May 29, 2022
Merged

haskellPackages: update stackage and hackage #173800

merged 29 commits into from
May 29, 2022

Conversation

maralorn
Copy link
Member

This Merge

This PR is the regular merge of the haskell-updates branch into master.

This branch is being continually built and tested by hydra at https://hydra.nixos.org/jobset/nixpkgs/haskell-updates. You may be able to find an up-to-date Hydra build report at cdepillabout/nix-haskell-updates-status.

We roughly aim to merge these haskell-updates PRs at least once every two weeks. See the @NixOS/haskell team calendar for who is currently in charge of this branch.

haskellPackages Workflow Summary

Our workflow is currently described in pkgs/development/haskell-modules/HACKING.md.

The short version is this:

  • We regularly update the Stackage and Hackage pins on haskell-updates (normally at the beginning of a merge window).
  • The community fixes builds of Haskell packages on that branch.
  • We aim at at least one merge of haskell-updates into master every two weeks.
  • We only do the merge if the mergeable job is succeeding on hydra.
  • If a maintained package is still broken at the time of merge, we will only merge if the maintainer has been pinged 7 days in advance. (If you care about a Haskell package, become a maintainer!)

This is the follow-up to #172982. Come to #haskell:nixos.org if you have any questions.

matthewbauer and others added 5 commits May 5, 2022 12:01
Using $TMPDIR here is problematic because it is not always cleared at
the end of each build, for instance when using "nix-shell --run
genericBuild". This can cause confusing errors when a nix-shell build
is trying to pull in dependencies from a previous build since it tries
to use older package conf files.

To fix, we can just use mktemp which will guarantee us a clean
directory for each build. Should have no effect in nix-build, but will
fix a common issue with using generic-builder in nix-shell.
Currently, the test output is only printed if the test suite fails. If a
test suite gets stuck, however, and is hit with a timeout by Hydra, it
can help to have the log available when diagnosing the issue.
This commit has been generated by maintainers/scripts/haskell/update-stackage.sh
This commit has been generated by maintainers/scripts/haskell/update-hackage.sh
This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh
Jade Lovelace and others added 3 commits May 20, 2022 13:59
@cdepillabout
Copy link
Member

It looks like spago is now broken. It appears that there is a new version of one of its dependencies: bower-json-1.1.0.0. bower-json-1.1.0.0 only works with >= aeson-2.0. But I believe spago only works with < aeson-2.0. There are two ways I can see to fix this:

  1. Generate bower-json_1_0_0_1 (which works with < aeson-2.0) here in Nixpkgs and override spago to use it.
  2. Send a PR to spago getting it compatible with bower-json-1.1.0.0 (and >= aeson-2.0?) and then apply that patch here in Nixpkgs.

I'm not sure I'll have time to do either of these this week, but if someone is interested in looking at this, I'd happy to review a PR.

If no one takes a look at this over the next week or so, feel free to mark spago and haskellPackages.spago broken.

@maralorn
Copy link
Member Author

maralorn commented May 21, 2022

@cdepillabout Ah, didn‘t see your message in time. But I just did 1.

I have also opened an issue against spago: purescript/spago#887

@maralorn
Copy link
Member Author

@roberth hercules-ci-agent has a build failure, which you probably understand better than I do: https://hydra.nixos.org/build/177779194/nixlog/1/tail

@cdepillabout
Copy link
Member

@maralorn Oh great, thanks a lot! That works for me.

…neric-builder

haskell-modules/generic-builder.nix: use mktemp instead of TMPDIR
…stream-test

haskellPackages.mkDerivation: show test outputs as they happen
@maralorn
Copy link
Member Author

I have just triggered a set rebuild by merging #171685 and #172365.

See https://github.com/cdepillabout/nix-haskell-updates-status/tree/0097eb11d54c146a4976c9c476be3d732d656285 for the state of the branch before the rebuild.

@vcunat
Copy link
Member

vcunat commented May 21, 2022

Is this meant for 22.05? If not, I'd certainly cancel the builds now and postpone that after the current staging-next is merged in included in this.

EDIT: release schedule #165792

@maralorn
Copy link
Member Author

No, I was not planning to get this into 22.05. I guess I am fine with canceling this for a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants