Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-camo: init at 2.4.0 #172447

Merged
merged 1 commit into from
May 24, 2022
Merged

go-camo: init at 2.4.0 #172447

merged 1 commit into from
May 24, 2022

Conversation

viraptor
Copy link
Contributor

Description of changes

Add go-camo server.

go-camo is a go version of a camo server.

A camo server is a special type of image proxy that proxies non-secure images over SSL/TLS, in order to prevent mixed content warnings on secure pages. The server works in conjunction with back-end code that rewrites image URLs and signs them with an HMAC.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label May 11, 2022
@ofborg ofborg bot requested a review from kalbasit May 11, 2022 04:50
@SuperSandro2000 SuperSandro2000 merged commit 5ce6597 into NixOS:master May 24, 2022
@SuperSandro2000
Copy link
Member

Now we only need a module for go-camo and it can be easily integrated into gitea 1.17.

@viraptor
Copy link
Contributor Author

@SuperSandro2000 Interesting. I haven't written one of those yet, but maybe now's the time to try :)

@SuperSandro2000
Copy link
Member

I didn't close enough attention when merging and there are some tests which try to access the internet which does not work in the sandbox. Going to fix that in a PR.

@viraptor viraptor deleted the add-go-camo branch May 25, 2022 23:50
@viraptor viraptor mentioned this pull request Jun 25, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants