Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-geiger: fix darwin build failures #172226

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

06kellyjac
Copy link
Member

Description of changes

Fix cargo-geiger build for darwin

A dependency curl-sys wanted some curl bits on darwin. It was broken since my last PR updated cargo-geiger :(

I think the CoreFoundation bit can just be moved into buildInputs. It worked ok in my VM

cc: @evanjs

Part of ZHF #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@06kellyjac 06kellyjac requested a review from evanjs May 9, 2022 17:22
@06kellyjac
Copy link
Member Author

image

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 172226 run on x86_64-linux 1

1 package built:
  • cargo-geiger

@siraben
Copy link
Member

siraben commented May 9, 2022

Result of nixpkgs-review pr 172226 run on aarch64-darwin 1

1 package built:
  • cargo-geiger

@siraben siraben merged commit eb935d1 into NixOS:master May 9, 2022
@06kellyjac 06kellyjac deleted the cargo-geiger branch May 9, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants