Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dosfstools: fix build failure in darwin #172212

Merged
merged 1 commit into from
May 9, 2022
Merged

dosfstools: fix build failure in darwin #172212

merged 1 commit into from
May 9, 2022

Conversation

otavio
Copy link
Contributor

@otavio otavio commented May 9, 2022

Log of error: https://hydra.nixos.org/build/175255572/nixlog/1
Refs: #172160
Signed-off-by: Otavio Salvador otavio@ossystems.com.br

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@otavio otavio requested a review from thiagokokada May 9, 2022 16:29
@thiagokokada
Copy link
Contributor

thiagokokada commented May 9, 2022 •
edited
Loading

Please squash your commits.

@otavio
dosfstools: fix build failure in darwin
8272001 
Log of error: https://hydra.nixos.org/build/175255572/nixlog/1
Refs: ZHF NixOS#172160
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@otavio otavio requested a review from thiagokokada May 9, 2022 17:17
Mindavi
Mindavi approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@Mindavi Mindavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff / patch LGTM

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 172212 run on x86_64-darwin 1

1 package built:
  • dosfstools

@thiagokokada
Copy link
Contributor

Tested and seems to be working fine.

@thiagokokada
Copy link
Contributor

@ofborg eval

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 9, 2022
@siraben
Copy link
Member

siraben commented May 9, 2022

Result of nixpkgs-review pr 172212 run on aarch64-darwin 1

1 package built:
  • dosfstools

@siraben siraben merged commit 888c0bd into NixOS:master May 9, 2022
@otavio otavio deleted the topic/fix-dosfstools branch May 10, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@Mindavi Mindavi Mindavi approved these changes

Assignees
No one assigned
Labels
0.kind: build failure 6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@otavio @thiagokokada @siraben @Mindavi