-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emscriptenStdenv: create writable cache directory #172207
Conversation
Additionally, referencing ZHF: #172160 |
|
This is great, thank you so much @willcohen !! |
@NixOS/release-engineers |
Thank you! |
Hi, I wonder if it is possible to document this in |
See #181363! |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/improving-an-emscripten-yarn-dev-shell-flake/33045/1 |
Description of changes
In the
configurePhase
ofemscriptenStdenv
, create a subdirectory that can be used for the internal emscripten cache. Fixes #139943 and #170621.Issue broke zlib with the update to 3.0 in #149083.
Additionally this modified the derivation for
zlib
to just use theemscriptenStdenv
configure phase, and then adds the same changes to the other derivations that make larger modifications.@arximboldi @busti
@qknight @matthewbauer
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes