Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.proton-client|protonvpn-nm-lib: change platform to linux #172190

Merged
merged 2 commits into from
May 9, 2022

Conversation

WolfangAukang
Copy link
Contributor

@WolfangAukang WolfangAukang commented May 9, 2022

Description of changes

#172160. Packages (used by protonvpn-cli and protonvpn-gui) are not intended to build on another platform outside of Linux.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@WolfangAukang
Copy link
Contributor Author

Pinging @NixOS/nixos-release-managers

@davidak
Copy link
Member

davidak commented May 9, 2022

Result of nixpkgs-review pr 172190 run on x86_64-linux 1

Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good

Evaluates

@davidak davidak merged commit 5d52f39 into NixOS:master May 9, 2022
@WolfangAukang WolfangAukang deleted the proton-client-platform branch May 13, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants