Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tkinter/matplotlib: mark tkinter broken if missing, omit from matplotlib #170565

Closed
wants to merge 2 commits into from
Closed

tkinter/matplotlib: mark tkinter broken if missing, omit from matplotlib #170565

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2022

Description of changes

The tkinter derivation apparently downloads binaries rather than
building from source. Let's mark the package broken on platforms for
which no binaries are available.

Let's also omit tkinter support from matplotlib on platforms where
tkinter is broken.

Things done
  • Built on platform(s)
    • powerpc64le-linux
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ghost ghost marked this pull request as ready for review April 27, 2022 04:24
@ghost ghost requested review from FRidh and jonringer as code owners April 27, 2022 04:24
@ghost
Copy link
Author

ghost commented Jun 21, 2022

Ping...

@FRidh
Copy link
Member

FRidh commented Jun 22, 2022

It should inherit this meta from the base Python derivation from which the tkinter module is taken.

@FRidh
Copy link
Member

FRidh commented Aug 4, 2022

tkinter is built from source. py is pythonXYFull. So, if pythonXYFull is built for Power64 and that built comes with tkinter, then this tkinter derivation will copy that part.

@FRidh FRidh closed this Aug 4, 2022
@ghost ghost deleted the powerpc64le-tkinter branch January 23, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant