webrtc-audio-processing: enable powerpc64le #170191
Conversation
|
@ofborg eval |
pkgs/development/libraries/webrtc-audio-processing/enable-powerpc.patch
Outdated
Show resolved
Hide resolved
|
Bummer that this causes so much rebuild. If you prefer I can make the patch conditional on the |
ghost
marked this pull request as draft
|
Okay, let's see if I remember how to change the base branch without mass-inviting every single nixpkgs reviewer.... ::crosses fingers:: |
This commit enables powerpc64le for webrtc-audio-processing, following the pattern established by riscv64 support in f13cf5e.
ghost
marked this pull request as ready for review
|
I originally wrote this patch a few days ago, and earlier today I found out that Gentoo hard written a much more complete version of it as part of their qtwebengine support. I've updated this PR to include the Gentoo version, and credited them at the top of the patch. |
|
Thanks. Staging is closed until 2022-May-15 so I will mark this as draft until then to keep it off of the maintainers' to-do list. |
ghost
marked this pull request as draft
|
Btw, contributing now contains a guide describing the rebase process for retargeting 👍 |
|
Staging is not closed, see #165792. Also, this looks quite safe to me. |
ghost
marked this pull request as ready for review
You're right. Sorry about that. The other staging PRs I have affect stdenv, so I had been thinking of the earlier 17-Apr deadline. |
|
No worries :). Cross-compiled for aarch64-multiplatform as well, let's get this in. |
Description of changes
This commit enables powerpc64le for webrtc-audio-processing, following
the pattern established by riscv64 support in f13cf5e.
It is unfortunate that upstream doesn't use tooling that can figure
out endianness by querying the compiler (e.g. autoconf, cmake, meson,
etc all know how to do this).
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)