Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coreboot-toolchain: Update to version 4.16 #159983

Merged
merged 2 commits into from
Feb 26, 2022
Merged

coreboot-toolchain: Update to version 4.16 #159983

merged 2 commits into from
Feb 26, 2022

Conversation

felixsinger
Copy link
Member

Motivation for this change

Update to version 4.16.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@felixsinger
coreboot-toolchain: Fix update script
c1cb95b 
coreboot-toolchain is a package set now and contains the toolchains for
various platforms. Thus, fix the update script by renaming the package
name to `coreboot-toolchain.i386`.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
@felixsinger felixsinger marked this pull request as ready for review February 26, 2022 03:51
@felixsinger
Copy link
Member Author

@GrahamcOfBorg build coreboot-toolchain.i386 coreboot-toolchain.arm coreboot-toolchain.aarch64 coreboot-toolchain.riscv coreboot-toolchain.ppc64 coreboot-toolchain.nds32le coreboot-toolchain.x64

@felixsinger
coreboot-toolchain: 4.15 -> 4.16
953c9a5 
Signed-off-by: Felix Singer <felixsinger@posteo.net>
@piegamesde piegamesde merged commit 4c7d3f9 into NixOS:master Feb 26, 2022
@felixsinger felixsinger deleted the pkgs/coreboot-toolchain/update branch February 26, 2022 22:41
@ghost
Copy link

ghost commented May 2, 2022 •
edited by ghost
Loading

By the way, thank you so much for nixifying this. It saved me a significant chunk of the work needed to migrate my crazy rube-goldberg bootloader to nix!

Okay, here's the problem. This derivation patches the shebangs inside of fetchgit.

This means that /nix/store/4nmqxajzaf60yjribkgvj5j54x9yvr1r-bash-5.1-p12/bin/sh (stdenv.shell at the time the expression was written) is now hardwired into this derivation. Anybody who does anything that changes the store-path of stdenv.shell (like, an overlay that applies -march=xyz) will be unable to build this.

Edit: I have a PR to address this, and guard against it happening in the future.

@ghost
Copy link

ghost commented May 2, 2022

#171223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maralorn maralorn Awaiting requested review from maralorn

@piegamesde piegamesde Awaiting requested review from piegamesde

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixsinger @piegamesde