Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages.libcxx: unset _LIBCPP_USE_AVAILABILITY_APPLE #151151

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 18, 2021

Should fix a common regression from #126411
Can go to staging or staging-next depending on how fast this can be reviewed, or whether we have time for a quick darwin stdenv rebuild.
cc #148396

@veprbl veprbl force-pushed the pr/libcxx_no_apple_availability branch from 9f9e8ed to e1aaaa9 Compare December 18, 2021 15:09
@veprbl veprbl requested review from vcunat and domenkozar December 18, 2021 15:21
@vcunat vcunat removed their request for review December 18, 2021 15:40
@vcunat
Copy link
Member

vcunat commented Dec 18, 2021

(I generally know almost nothing about Apple-specific stuff.)

@veprbl
Copy link
Member Author

veprbl commented Dec 18, 2021

(I generally know almost nothing about Apple-specific stuff.)

I don't think many of us feel like they do :) In this instance I was pinging you because: you are watching over the staging-next regressions. Also I need help deciding where this change should go this or next staging iteration, and you probably have a better idea about timeline and amount of acceptable breakages for this.

@vcunat
Copy link
Member

vcunat commented Dec 18, 2021

I'm not sure how bad these issues are. Hydra isn't very busy now, but the current staging-next iteration has been running for relatively long time (over two weeks) and full x86_64-darwin rebuild would surely add at least several days.

@risicle
Copy link
Contributor

risicle commented Dec 18, 2021

(am attempting to build the packages which have had their tweaks removed...)

@veprbl
Copy link
Member Author

veprbl commented Dec 19, 2021

Result of nixpkgs-review pr 151151 run on x86_64-darwin 1

1 package built:
  • nix

@risicle
Copy link
Contributor

risicle commented Dec 19, 2021

Not entirely sure how it's related but I get:

builder for '/nix/store/sfjsywkwvyfhc4dbvmm3fwllajl1l7c3-automake-1.16.5.drv' failed with exit code 2; last 10 log lines:
    GEN      doc/aclocal.1
    GEN      lib/Automake/Config.pm
    GEN      runtest
    GEN      t/ax/cc-no-c-o
    GEN      t/ax/shell-no-trail-bslash
    GEN      t/ax/test-defs.sh
    GEN      doc/automake-1.16.1
  help2man: can't get `--help' info from automake-1.16
  Try `--no-discard-stderr' if option outputs to stderr
  make: *** [Makefile:3743: doc/automake-1.16.1] Error 127

on macos 10.15. This is from a nixpkgs-review started approx 24h ago when staging-next head was 2add175

@veprbl
Copy link
Member Author

veprbl commented Dec 19, 2021

@risicle I think saw this error on x86_64-linux recently. Although I don't remember what that was about, could be that I just worked it around by enabling sandboxing.

@veprbl veprbl merged commit bbea487 into NixOS:staging-next Dec 19, 2021
@veprbl
Copy link
Member Author

veprbl commented Dec 19, 2021

Let's pull the trigger on this. The issue affects compilation with never standards, so users will definitely be affected if we don't fix it now.

@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants