build-support/rust: Organize #144193
Merged
build-support/rust: Organize #144193
+50
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested review from
andir,
LnL7,
Mic92 and
zowoq
as code owners
|
Eval error looks legit. |
- `toRustTarget` and friends pulled out from rust tools into rust library. Since they don't depend on any packages they can be more widely useable. - `build-rust-package` gets its own directory - `fetch-cargo-tarball` gets its own directory
Ericson2314
force-pushed
the
rust-build-support-org
branch
from
c20d442 to
18ed048
Compare
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-21.05
git worktree add -d .worktree/backport-144193-to-release-21.05 origin/release-21.05
cd .worktree/backport-144193-to-release-21.05
git checkout -b backport-144193-to-release-21.05
ancref=$(git merge-base 3b0bff383f8e894b1ee7a30b62c8b727a68511df 18ed048c7b27e288a6c9ba894790a7e67ed5080d)
git cherry-pick -x $ancref..18ed048c7b27e288a6c9ba894790a7e67ed5080d |
1 similar comment
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-21.05
git worktree add -d .worktree/backport-144193-to-release-21.05 origin/release-21.05
cd .worktree/backport-144193-to-release-21.05
git checkout -b backport-144193-to-release-21.05
ancref=$(git merge-base 3b0bff383f8e894b1ee7a30b62c8b727a68511df 18ed048c7b27e288a6c9ba894790a7e67ed5080d)
git cherry-pick -x $ancref..18ed048c7b27e288a6c9ba894790a7e67ed5080d |
12 tasks
|
this created a merge conflict in #144730 |
|
@figsoda OK I will fix |
|
On the command line, it was conveniently not a conflict! Fixed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
toRustTargetand friends pulled out from rust tools into rustlibrary. Since they don't depend on any packages they can be more
widely useable.
build-rust-packagegets its own directoryfetch-cargo-tarballgets its own directoryThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)