plasma-workspace: fix app_id by moving bin/.plasmashell-wrapped to #139213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
force-pushed
the
plasmashellid
branch
from
4334c55 to
b6b6dfa
Compare
ofborg
bot
added
10.rebuild-darwin: 0
|
to test: {
inputs = {
nixpkgs.url = "github:Artturin/nixpkgs/plasmashellid";
nixpkgs1.url = "github:Artturin/nixpkgs/plasmawayland";
};
outputs = inputs@{ self, nixpkgs, nixpkgs1 }: {
nixosConfigurations.vm = nixpkgs.lib.nixosSystem {
system = "x86_64-linux";
specialArgs = { inherit inputs; };
modules = [
({ pkgs, ... }: {
disabledModules = [ "services/x11/desktop-managers/plasma5.nix" ];
imports = [
"${inputs.nixpkgs1}/nixos/modules/services/x11/desktop-managers/plasma5.nix"
## For virtualisation settings
"${inputs.nixpkgs}/nixos/modules/virtualisation/qemu-vm.nix"
];
environment.systemPackages = with pkgs; [
libnotify
];
services.xserver = {
enable = true;
displayManager.sddm = {
enable = true;
settings.Wayland.SessionDir =
"${pkgs.plasma5Packages.plasma-workspace}/share/wayland-sessions";
};
desktopManager.plasma5 = {
enable = true;
runUsingSystemd = true;
};
};
# Documentation for these is in nixos/modules/virtualisation/qemu-vm.nix
virtualisation = {
memorySize = 1024 * 3;
diskSize = 1024 * 4;
cores = 4;
msize = 104857600;
};
boot.tmpOnTmpfs = true;
documentation.enable = false;
users.mutableUsers = false;
users.defaultUserShell = pkgs.zsh;
users.users.root = {
password = "root";
};
users.users.user = {
password = "user";
isNormalUser = true;
extraGroups = [ "wheel" ];
};
})
];
};
# So that we can just run 'nix run' instead of
# 'nix build ".#nixosConfigurations.vm.config.system.build.vm" && ./result/bin/run-nixos-vm'
defaultPackage.x86_64-linux = self.nixosConfigurations.vm.config.system.build.vm;
defaultApp.x86_64-linux = {
type = "app";
program = "${self.defaultPackage.x86_64-linux}/bin/run-nixos-vm";
};
};
}then in a terminal in the vm run |
|
Wouldn't this be better handled at the root location that is checking for binary name? In a similar fashion to this one: We're likely to play whack-a-mole otherwise. |
|
Result of 34 packages skipped due to time constraints:
16 packages built successfully:
Result of 33 packages skipped due to time constraints:
16 packages built successfully:
|
|
|
My 2 cents: It seems the fix has 2 requirements which kind of conflict with each other with current
A possible generic solution I can see would be the original package and its unwrapped binaries be put in a separate derivation, in this case, an internal This would then possibly add the problem where other packages that expect other files (other binaries, share, lib, etc) to be present in |
bin/plasmashell.wrapped Closes NixOS#118650
Artturin
force-pushed
the
plasmashellid
branch
from
b6b6dfa to
50b663f
Compare
|
I have discovered a better/simpler solution which is to just change the |
|
oh... like this no programs appear in the task bar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bin/plasmashell.wrapped
Closes #118650
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)