Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: fix update script indentation #134050

Merged
merged 1 commit into from
Aug 14, 2021
Merged

vimPlugins: fix update script indentation #134050

merged 1 commit into from
Aug 14, 2021

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Aug 14, 2021

Motivation for this change

pkgs/misc/vim-plugins/update.py generates extra indentation and editorconfig rules

#133296 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

lovesegfault
lovesegfault approved these changes Aug 14, 2021
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this fixes it!

@lovesegfault lovesegfault merged commit 66c4266 into NixOS:master Aug 14, 2021
@lovesegfault lovesegfault mentioned this pull request Aug 14, 2021
Merged
11 tasks
@figsoda figsoda deleted the fix-vim-update branch August 14, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@figsoda @lovesegfault