Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox: add smartcard support through opensc #132797

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

gardspirito
Copy link
Contributor

@gardspirito gardspirito commented Aug 5, 2021

I'm an idiot who messed up with git and unintentionally posted multiple review requests. Please, forgive ne.

Motivation for this change

Conditionally provides Frefox with access to opensc library and includes the respective PKCS#11 module via policies.json. This allows to use external PKCS#11-based devices such as smartcards with Firefox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 5, 2021
@gardspirito gardspirito changed the title firefox: opensc pkcs11 modules support firefox: opensc pkcs11 module support Aug 5, 2021
@gardspirito
Copy link
Contributor Author

Ping @lovesegfault

@gardspirito
Copy link
Contributor Author

Also, I'm new to nixpkgs, so I don't know whether this should be fixed here, but smart cards support also requires services.pcscd.enable = true;.

@lovesegfault
Copy link
Member

Also, I'm new to nixpkgs, so I don't know whether this should be fixed here, but smart cards support also requires services.pcscd.enable = true;.

You can add a comment in the pkg derivation if you want.

@lovesegfault
Copy link
Member

Alright, this is looking good!

Please squash the commits and I'll merge it. Message should read:

firefox: add smartcard support through opensc

@gardspirito gardspirito requested a review from stigtsp as a code owner August 6, 2021 22:28
@github-actions github-actions bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Aug 6, 2021
@github-actions github-actions bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Aug 6, 2021
@github-actions github-actions bot added 6.topic: python 6.topic: rust 8.has: documentation This PR adds or changes documentation labels Aug 6, 2021
@github-actions github-actions bot removed 6.topic: rust 6.topic: python 8.has: documentation This PR adds or changes documentation labels Aug 6, 2021
@gardspirito
Copy link
Contributor Author

Done.

Please, don't ask any questions... I want to forget about this nightmare and my incompetence.

@gardspirito gardspirito changed the title firefox: opensc pkcs11 module support firefox: add smartcard support through opensc Aug 6, 2021
@lovesegfault lovesegfault merged commit 44caf8f into NixOS:master Aug 6, 2021
@lovesegfault
Copy link
Member

Thanks for the contribution!

@gardspirito gardspirito deleted the laboro branch August 6, 2021 23:06
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants