Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-21.05] linux/common-config.nix: disable LPAE on armv7l-linux #132162

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 30, 2021

Bot-based backport to release-21.05, triggered by a label in #132100.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

LPAE was enabled to support native armv7l builders running in QEMU on aarch64,
but this option disables support for processors which don't support LPAE, which
are still relatively common. In particular, Beaglebones use the Cortex-A8, which
doesn't support LPAE.

Also, if you attempt to boot an LPAE kernel on a CPU that doesn't support it,
it fails before even earlycon is initialized. This makes the problem difficult
to debug without enabling CONFIG_DEBUG_LL or using a hardware debugger.

(cherry picked from commit 988c12f)
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 30, 2021
@samueldr
Copy link
Member

As this fixes a bug introduced before 21.05 was forked, yes this fits the criteria for backporting.

As armv7 is not a higher tier platform, it's unlikely we had users relying on LPAE since the recent change. Especially considering native armv7 builds were not working correctly for a while.

@github-actions github-actions bot added the 6.topic: kernel The Linux kernel label Jul 30, 2021
@samueldr samueldr merged commit a8d7cc1 into release-21.05 Jul 30, 2021
@samueldr samueldr deleted the backport-132100-to-release-21.05 branch July 30, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants