support installation of luarocks packages as vim plugins #131499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
| rapidjson,,,,, | ||
| readline,,,,, | ||
| say,,,,, | ||
| std__debug,std._debug,,,, | ||
| std-_debug,std._debug,,,, |
There was a problem hiding this comment.
normalization is not fully working.
There was a problem hiding this comment.
what do you mean ? original package name is std._debug it gets renamed to std-_debug.
Comment on lines
93
to
94
| # Normalize package name | ||
| nix_pkg_name_normalized=$(sed 's/\./-/' <(echo "$nix_pkg_name")) |
There was a problem hiding this comment.
Suggested change
| # Normalize package name | |
| nix_pkg_name_normalized=$(sed 's/\./-/' <(echo "$nix_pkg_name")) | |
| # Normalize package name | |
| nix_pkg_name_normalized=$(sed 's/\./-/' <(echo "$nix_pkg_name")) |
Comment on lines
10
to
42
| # this is an approximation | ||
| target="$out/$rtpPath/$pname" | ||
| mkdir -p $out/${rtpPath} | ||
| cp -r . $target | ||
|
|
||
| # build help tags | ||
| if [ -d "$target/doc" ]; then | ||
| echo "Building help tags" | ||
| if ! @vimBinary@ -N -u NONE -i NONE -n -E -s -V1 -c "helptags $target/doc" +quit!; then | ||
| echo "Failed to build help tags!" | ||
| exit 1 | ||
| fi | ||
| else | ||
| echo "No docs available" | ||
| fi | ||
|
|
||
| if [ -n "$addonInfo" ]; then | ||
| echo "$addonInfo" > $target/addon-info.json | ||
| fi | ||
| runHook postInstall | ||
| echo "Finished executing vimPluginInstallPhase" | ||
| } |
There was a problem hiding this comment.
This is formated inconsistend.
|
I am now able to install neovim lua packages registered on luarocks via this, for instance gitsigns.nvim. Should be mostly ready. |
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 501+
10.rebuild-linux: 1001-2500
labels
This commit shows how to convert luarocks packages into (neo)vim ones. The advantage for neovim lua plugins to register their rockspec (aka package definition) is that the plugin can express its dependencies and a few metadata through it.
teto
changed the title
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
neovim has a vibrant lua ecosystem and I would like to encourage vim plugin authors to rely on luaroicks rather than having every user specify the dependencies themselves. May lead nowhere.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)