Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-machete: add test and update script #131141

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Conversation

blitz
Copy link
Contributor

@blitz blitz commented Jul 22, 2021

Motivation for this change

Add an update script and a simple version test for git-machete to allow fearless automatic updates by @r-ryantm.

I've tried out the update script via nix-shell ./maintainers/scripts/update.nix --argstr package git-machete and it works for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@PawelLipski

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 22, 2021
Copy link
Contributor

@PawelLipski PawelLipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I'm leaving my approval :)

@blitz blitz requested review from tfc and SuperSandro2000 July 22, 2021 22:23
@PawelLipski
Copy link
Contributor

@blitz out of curiosity, how often does @r-ryantm perform its update? is it cronned somehow?

@blitz
Copy link
Contributor Author

blitz commented Jul 25, 2021

@blitz out of curiosity, how often does @r-ryantm perform its update? is it cronned somehow?

I couldn't recognize a pattern beyond "it eventually comes along". Maybe @ryantm knows? :)

@ryantm
Copy link
Member

ryantm commented Jul 25, 2021

It's basically always trying to make updates, but sometimes it gets stuck building something.

@SuperSandro2000
Copy link
Member

Also nix-update would handle this without the addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants