Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot: 0.9.6 -> 0.9.7 #128307

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 27, 2021

Motivation for this change

Bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Relase notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from akru, andresilva and FlorianFranzen June 27, 2021 12:20
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 27, 2021
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 128307 run on x86_64-linux 1

1 package built:
  • polkadot

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the cargo.lock file actually used anywhere?

@asymmetric
Copy link
Contributor Author

asymmetric commented Jun 28, 2021

@SuperSandro2000 excellent point. No, I was trying to use it with the features introduced in #122158, but that didn't work (one of the hashes in the Cargo.lock seems to be too short for Nix), so I went back to the usual approach, but forgot to remove the file.

Removed it, thanks for the thorough review!

/cc @danieldk in case you've seen errors like this one before.

@ofborg ofborg bot requested a review from RaghavSood June 28, 2021 14:59
@SuperSandro2000 SuperSandro2000 merged commit e714ecc into NixOS:master Jun 28, 2021
@asymmetric asymmetric deleted the polkadot/0.9.7 branch June 29, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants