Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quickbms: init at 0.11.0 #121523

Merged
merged 1 commit into from
May 8, 2021
Merged

quickbms: init at 0.11.0 #121523

merged 1 commit into from
May 8, 2021

Conversation

samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented May 2, 2021 •
edited
Loading

Motivation for this change

QuickBMS is a useful tool for extracting tons of different archive formats (there are 2661 scripts officially available here: http://aluigi.altervista.org/quickbms_scripts.php).
This can be used to extract some Windows installers, making it possible to package the files in Nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 2, 2021
@samuelgrf samuelgrf force-pushed the quickbms-init-at-0.11.0 branch from e8d33b3 to 8d16117 Compare May 2, 2021 17:08
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 2, 2021
@samuelgrf samuelgrf removed the ofborg-internal-error Ofborg encountered an error label May 2, 2021
@samuelgrf samuelgrf force-pushed the quickbms-init-at-0.11.0 branch from 8d16117 to 5723c4c Compare May 2, 2021 18:14
@samuelgrf samuelgrf requested a review from SuperSandro2000 May 4, 2021 19:45
@samuelgrf samuelgrf mentioned this pull request May 7, 2021
Closed
jonringer
jonringer approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/121523

1 package built:
quickbms

@jonringer jonringer merged commit 7c710c8 into NixOS:master May 8, 2021
@samuelgrf samuelgrf deleted the quickbms-init-at-0.11.0 branch March 5, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@jonringer jonringer jonringer approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelgrf @jonringer @symphorien