Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/geoipupdate: Replace the old geoip-updater module #121145

Merged
merged 1 commit into from
Jun 3, 2021
Merged

nixos/geoipupdate: Replace the old geoip-updater module #121145

merged 1 commit into from
Jun 3, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Apr 29, 2021

Motivation for this change

Our old bespoke GeoIP updater doesn't seem to be working anymore. Instead of trying to fix it, let's replace it with the official updater from MaxMind.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz requested a review from bjornfor April 29, 2021 10:03
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Apr 29, 2021
@talyz talyz requested a review from dasJ April 29, 2021 10:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 29, 2021
SuperSandro2000
SuperSandro2000 reviewed Apr 30, 2021
View reviewed changes
nixos/modules/services/misc/geoipupdate.nix
after = [ "network-online.target" "nss-lookup.target" ];
wants = [ "network-online.target" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the program retry when no network is available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. There is a configuration parameter for how long it should retry for on HTTP errors, but it might just give up if there's no network at all.

@talyz talyz mentioned this pull request May 16, 2021
Closed
@talyz talyz requested review from mmilata and infinisil May 22, 2021 09:18
@talyz talyz requested a review from ryantm as a code owner June 2, 2021 17:11
@talyz talyz mentioned this pull request Jun 2, 2021
Merged
9 tasks
@talyz
nixos/geoipupdate: Replace the old geoip-updater module
f5f8341 
Our old bespoke GeoIP updater doesn't seem to be working
anymore. Instead of trying to fix it, replace it with the official
updater from MaxMind.
@talyz
Copy link
Contributor Author

talyz commented Jun 3, 2021

I'll merge this now - it feels rather uncontroversial and we're far from next stable, so there's plenty of time to address potential issues.

@talyz talyz merged commit bd1630e into NixOS:master Jun 3, 2021
@talyz talyz deleted the geoipupdate branch June 3, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@fadenb fadenb fadenb approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

@mmilata mmilata Awaiting requested review from mmilata

@infinisil infinisil Awaiting requested review from infinisil

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talyz @fadenb @dasJ @SuperSandro2000