Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixUnstable: 3.0pre20200829_f156513 -> 3.0pre20201020_e0ca98c #101245

Merged
merged 1 commit into from
Oct 21, 2020
Merged

nixUnstable: 3.0pre20200829_f156513 -> 3.0pre20201020_e0ca98c #101245

merged 1 commit into from
Oct 21, 2020

Conversation

edolstra
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Oct 21, 2020

@edolstra related: #98973

@edolstra
Copy link
Member Author

@Ma27 Thanks, didn't see that PR. I'll merge this one since it has some more cleanups to the Nix expression. Could you rebase yours?

@edolstra edolstra merged commit c4b26e7 into NixOS:master Oct 21, 2020
@edolstra edolstra deleted the bump-nix-unstable branch October 21, 2020 16:00
@Ma27
Copy link
Member

Ma27 commented Oct 21, 2020

@edolstra done, now it only contains the Hydra bump %)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edolstra @Ma27