Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos-install: pass through impure flag #100136

Merged
merged 1 commit into from
Oct 31, 2020
Merged

nixos-install: pass through impure flag #100136

merged 1 commit into from
Oct 31, 2020

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Oct 10, 2020 •
edited
Loading

Motivation for this change

resolve #99114

Its especially important because NixOS/nix#4081 is preventing building installing of flake based systems without --impure at the time of writing.

Things done
  • Built the nixos manpages
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Oct 10, 2020
@xaverdh
Copy link
Contributor Author

xaverdh commented Oct 10, 2020

Side remark: The situation around the nixos-* tools is somewhat sub-optimal in general, because the various nix options have to be kept in sync in several places like this. Would probably benefit from rewriting as a single executable / script.

@xaverdh
Copy link
Contributor Author

xaverdh commented Oct 10, 2020

cc @worldofpeace

@worldofpeace worldofpeace requested a review from cole-h October 10, 2020 18:27
worldofpeace
worldofpeace approved these changes Oct 10, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but look correct

cole-h
cole-h approved these changes Oct 11, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as worldofpeace -- diff LGTM, but untested.

@worldofpeace
Copy link
Contributor

@ofborg test installer.simple

@worldofpeace worldofpeace merged commit 7b3b82f into NixOS:master Oct 31, 2020
@ShamrockLee ShamrockLee mentioned this pull request Feb 6, 2021
Merged
10 tasks
ShamrockLee pushed a commit to ShamrockLee/nixpkgs that referenced this pull request Feb 12, 2021
@xaverdh @ShamrockLee
nixos-install: pass through impure flag
22347e0 
(cherry picked from commit bb61cce)
Backport of NixOS#100136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos-install doesn't support --impure flakes
3 participants
@xaverdh @worldofpeace @cole-h