Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torch is busted #71888

Closed
Fresheyeball opened this issue Oct 24, 2019 · 3 comments
Closed

Torch is busted #71888

Fresheyeball opened this issue Oct 24, 2019 · 3 comments
Labels
0.kind: bug 2.status: wontfix 6.topic: lua 9.needs: clean-up

Comments

@Fresheyeball
Copy link

https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/science/machine-learning/torch/default.nix

This shit is broke. We should mark it broke, or fix it.
@coreyoconnor
Copy link
Contributor

to be pedantic: Dependencies in the torch distribution are already marked as broken. One cannot currently build a top level torch derivation as it's deps are marked broken.

Does this constitute being marked broken already? Not sure.

Does being marked broken for such a long time mean we should remove it? I think so.

@teto
Copy link
Member

teto commented Oct 24, 2019

I mentioned this issue last week in
#56398 (comment). It could
be reimplemented by using the new architecture.

@stites stites mentioned this issue Oct 24, 2019
Open
30 tasks
teto added a commit to teto/nixpkgs that referenced this issue Feb 27, 2020
@teto
torchPackages, torch-repl: remove
3a11be5 
See NixOS#71888
and NixOS#56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.
@teto teto mentioned this issue Feb 27, 2020
Merged
10 tasks
teto added a commit that referenced this issue Feb 28, 2020
@teto
torchPackages, torch-repl: remove
05b6836 
See #71888
and #56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this issue Feb 29, 2020
@teto @dtzWill
torchPackages, torch-repl: remove
5517919 
See NixOS#71888
and NixOS#56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.

(cherry picked from commit 05b6836)
@teto teto closed this as completed Feb 29, 2020
nh2 pushed a commit to nh2/nixpkgs that referenced this issue Mar 28, 2020
@teto @nh2
torchPackages, torch-repl: remove
18c0784 
See NixOS#71888
and NixOS#56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.

(cherry picked from commit 05b6836)
@bhipple
Copy link
Contributor

bhipple commented Mar 28, 2020

Not only is it broken, it's completely unmaintained and dead upstream:

https://github.com/torch/torch7#development-status

As of 2019, the Torch-7 community is close to non-existent.

It appears that the useful bits have been ported over to pytorch, and the rest left to rot. Let's remove the remains.

@bhipple bhipple mentioned this issue Mar 28, 2020
Merged
10 tasks
bhipple added a commit to bhipple/nixpkgs that referenced this issue Mar 28, 2020
@bhipple
treewide: remove torch and related packages
698ec44 
See NixOS#71888 for details.
bhipple added a commit to bhipple/nixpkgs that referenced this issue Mar 28, 2020
@bhipple
aliases.nix: add aliases for removed torch packages
a80ed9f 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568
@bhipple bhipple mentioned this issue Mar 28, 2020
Merged
bhipple added a commit to bhipple/nixpkgs that referenced this issue Mar 28, 2020
@bhipple
treewide: remove torch and related packages
8f246db 
See NixOS#71888 for details.

(cherry picked from commit 698ec44)
bhipple added a commit to bhipple/nixpkgs that referenced this issue Mar 28, 2020
@bhipple
aliases.nix: add aliases for removed torch packages
4a3f221 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568

(cherry picked from commit a80ed9f)
@bhipple bhipple mentioned this issue Mar 28, 2020
Merged
stigok pushed a commit to stigok/nixpkgs that referenced this issue Jun 12, 2020
@teto @stigok
torchPackages, torch-repl: remove
50ef01f 
See NixOS#71888
and NixOS#56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.

(cherry picked from commit 05b6836)
stigok pushed a commit to stigok/nixpkgs that referenced this issue Jun 12, 2020
@bhipple @stigok
treewide: remove torch and related packages
7def5c9 
See NixOS#71888 for details.

(cherry picked from commit 698ec44)
stigok pushed a commit to stigok/nixpkgs that referenced this issue Jun 12, 2020
@bhipple @stigok
aliases.nix: add aliases for removed torch packages
bb3aa84 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568

(cherry picked from commit a80ed9f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug 2.status: wontfix 6.topic: lua 9.needs: clean-up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@coreyoconnor @veprbl @Fresheyeball @teto @bhipple @tomodachi94