Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fstar: fstarlib / fstar.lib not being installed anymore #275866

Closed
someplaceguy opened this issue Dec 21, 2023 · 1 comment · Fixed by #275924
Closed

fstar: fstarlib / fstar.lib not being installed anymore #275866

someplaceguy opened this issue Dec 21, 2023 · 1 comment · Fixed by #275924
Labels
0.kind: bug Something is broken

Comments

@someplaceguy
Copy link
Contributor

Describe the bug

In the F* package, it appears that fstarlib / fstar.lib is not being installed anymore:

$ ls /nix/store/gpfmizgg7d98p5a2c53iii2vlf9dqbng-fstar-2023.09.03/lib/ocaml/4.14.1/site-lib/fstarlib/
total 0

This makes it impossible to build programs written in F* and extracted to OCaml.

I suspect this problem was introduced in 20b2d94, as I believe in NixOS 23.05 this problem didn't exist.

Steps To Reproduce

  1. Build / install fstar.
  2. Look inside the Nix store installation directory to see the fstarlib / fstar.lib OCaml lib was not installed.

Expected behavior

I expected the library to be installed.

Notify maintainers

cc @marsam @gebner @pnmadelaine

Add a 👍 reaction to issues you find important.
@someplaceguy someplaceguy added the 0.kind: bug Something is broken label Dec 21, 2023
someplaceguy added a commit to someplaceguy/nixpkgs that referenced this issue Dec 21, 2023
@someplaceguy
fstar: add symlink to ocaml lib
3a6cc73 
Nix adds the library to OCAMLPATH automatically if the library is
installed in its standard Nix location.

This allows building F* programs extracted to OCaml more easily.
The library has been renamed to `fstar.lib`, though.

Some libraries need to be propagated as they are needed when
building a program that depends on `fstar.lib`.

Fixes NixOS#275866
@someplaceguy someplaceguy mentioned this issue Dec 21, 2023
Closed
13 tasks
@someplaceguy
Copy link
Contributor Author

someplaceguy commented Dec 21, 2023 •
edited
Loading

It turns out that the library is actually being installed, but not in its standard location.

Please see #275889 for a potential fix.

@pnmadelaine pnmadelaine mentioned this issue Dec 22, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0.kind: bug Something is broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fstar: build with dune pnmadelaine/nixpkgs
fstar: add symlink to ocaml lib someplaceguy/nixpkgs
1 participant
@someplaceguy