Skip to content

Commit

Permalink
qtwebengine: replace targetPlatform with hostPlatform
Browse files Browse the repository at this point in the history
stdenv.targetPlatform really shouldn't be used by software that
doesn't generate or manipulate binaries.

I did a mass-replacement in
#267229 and it affected eval
for only two packages; one of them is qt6-qtwebengine, but it is
affected only on Darwin.  So I am breaking this out into a separate
PR.
  • Loading branch information
Adam Joseph committed Nov 13, 2023
1 parent 771cae0 commit 91ac57c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/development/libraries/qt-6/modules/qtwebengine.nix
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ qtModule {
] ++ lib.optionals enableProprietaryCodecs [
"-DQT_FEATURE_webengine_proprietary_codecs=ON"
] ++ lib.optionals stdenv.isDarwin [
"-DCMAKE_OSX_DEPLOYMENT_TARGET=${stdenv.targetPlatform.darwinSdkVersion}"
"-DCMAKE_OSX_DEPLOYMENT_TARGET=${stdenv.hostPlatform.darwinSdkVersion}"
];

propagatedBuildInputs = [
Expand Down

0 comments on commit 91ac57c

Please sign in to comment.