Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention OPTIMIZE=0 more prominently in the hacking guide #9966

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

thufschmitt
Copy link
Member

This is a game-changer when developing, it shouldn't just be hidden amongst a list of more advanced variables.

Note that it's currently broken (#9965), so keeping it as a draft for now.

Depends on #9965

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

This is a game-changer when developing, it shouldn't just be hidden amongst a list of more advanced variables.
@tomberek
Copy link
Contributor

tomberek commented Feb 9, 2024

This sometimes has no effect as it is easy to end up with a call to g++ ... -O2 .... -O0 .... -O2 with opt flags overriding each other. I didn't trace this issue to a cause, but noticed that OPTIMIZE=0 sometimes has no effect.

@thufschmitt
Copy link
Member Author

This sometimes has no effect as it is easy to end up with a call to g++ ... -O2 .... -O0 .... -O2 with opt flags overriding each other. I didn't trace this issue to a cause, but noticed that OPTIMIZE=0 sometimes has no effect.

Yes, that's what #9965 mentions. I couldn't find how to change that (seems to be some builtin autoconf behaviour), hoping for someone more knowledgeable to chime in

@tomberek tomberek added the good first issue Quick win for first-time contributors label Feb 13, 2024
@thufschmitt thufschmitt marked this pull request as ready for review February 14, 2024 13:16
@thufschmitt thufschmitt merged commit bc9471d into master Feb 15, 2024
16 checks passed
@thufschmitt thufschmitt deleted the mention-OPTIMIZE-in-hacking-guide branch February 15, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Quick win for first-time contributors
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants