parse $ followed by a ' inside ind_string #773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <IND_STRING>(\'|\$) { | ||
| char str[2] = "'"; | ||
| str[0] = yytext[0]; | ||
| yylval->e = new ExprIndStr(str); | ||
| return IND_STR; | ||
| } | ||
| <IND_STRING>. return yytext[0]; /* just in case: shouldn't be reached */ |
There was a problem hiding this comment.
funilly, there's now a warning that this rule is never matched.
This is not yet true for the STRING case, I suppose because there this rule (that shouldn't be matched) is matched when a string ends with \ or $ at the end of a file. (this is still a little 'bad' because whenever it is matched we get an error unexpected $undefined from bison)
Previously, e. g. ''$'' or '' $' '' would fail with 'unexpected , expecting IND_STR or DOLLAR_CURLY or IND_STRING_CLOSE' This fixes NixOS#772
|
Waiting for @edolstra as the last two got reverted. |
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
zolodev
pushed a commit
to zolodev/nix
that referenced
this pull request
Jan 1, 2024
* team membership list follow up Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, e. g. ''$'' or '' $' '' would fail with 'unexpected $undefined, expecting IND_STR or DOLLAR_CURLY or IND_STRING_CLOSE'
This fixes #772