Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow XDG Base Directory standard #5588
Follow XDG Base Directory standard #5588
Changes from all commits
2384d36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
NIX_LINK_NEW=$HOME/.local/state/nix/profiles/profile/
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does make you think we want to profile/profiles? That looks like a bug to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SuperSandro2000 I'm not familiar with the nix source code, but when I do a single user install on a fresh docker ubuntu, nix adds the following sym link:
~/.nix-profile -> ~/.local/state/nix/profiles/profile
Do we not want this value to match that?
If
~/.nix-profile
doesn't exist and$XDG_STATE_HOME
is not set, we end up withNIX_LINK_NEW=$HOME/.local/state/nix/profile
but this link target doesn't exist on my install.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there is both
~/.local/
share
/nix/profiles/profile
and~/.local/
state
/nix/profile
. The former is the actual profile, the latter is a symlink to it. I think this should be simplified by putting the profiles instate
and removing the useless indirection (compatibility is only needed for~/.nix-profile
when not using xdg-base-dirs)(Or keep the profiles in
share
, we've had enough breakage already)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is what I called out in #5588 (comment). I think rather than trying to support 4(!) combinations, we should do all the XDG stuff (this and home directories) together so there are just 2 combinations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we want to check if the terminal supports those escape sequences but I bet it would be safe to assume it does.