Fix issue #11141 broken stack pointer corrector #11150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
roberth
force-pushed
the
issue-11141-broken-sp-corrector
branch
from
9b07359 to
380becf
Compare
edolstra
approved these changes
Jul 22, 2024
|
#11152 should allow us to get rid of the Boehm coroutine hacks altogether, but this fix and the test looks good. |
We might need this when multiple threads perform filtering, but not 100% sure.
Unfortunately I've had to disable it because its 2GB memory consumption is too much for our GHA CI, and probably not something we should require from users either. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-07-22-nix-team-meeting-minutes-163/49544/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #11141
The stack pointer corrector assigned the base instead of the top (which resides at the low end of the stack).
Sounds confusing?
Stacks grow downwards, so that's why this mistake happened.
My manual testing did not uncover this in #10835, because it didn't rely on the stack enough.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.