Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakes: Enhance Error when Files are not Added to Git #11253

Closed
Malix-Labs opened this issue Aug 4, 2024 · 6 comments
Closed

Flakes: Enhance Error when Files are not Added to Git #11253

Malix-Labs opened this issue Aug 4, 2024 · 6 comments
Labels
feature Feature request or proposal

Comments

@Malix-Labs
Copy link

Problem

Currently, about flakes development, the error when files are not added to git are not that helpful

Proposed Solution

Would be nice if nix inspected the source tree and if an untracked file did exist there, that it would give you a more helpful error to run git add -- <file>

Priorities

Add 👍 to issues you find important.

@Malix-Labs Malix-Labs added the feature Feature request or proposal label Aug 4, 2024
@hraban
Copy link
Member

hraban commented Aug 4, 2024

It would be nice if this functionality included support for the flake.nix file itself

@edolstra
Copy link
Member

edolstra commented Aug 5, 2024

Duplicate of #4507

@edolstra edolstra closed this as completed Aug 5, 2024
@Malix-Labs
Copy link
Author

Malix-Labs commented Aug 5, 2024

thanks @edolstra !

By the way, if you edit your comment by making its content only strictly be "Duplicate of #ID", it will be marked as duplicate

@edolstra edolstra marked this as a duplicate of #4507 Aug 5, 2024
@edolstra
Copy link
Member

edolstra commented Aug 5, 2024

@Malix-off Thanks for letting me know!

@hraban
Copy link
Member

hraban commented Aug 5, 2024

We're at risk of losing the 43 👍 votes for this issue if it just gets closed and marked as dupe without consolidating those, somehow. Don't know how much that matters but since the issue template explicitly asks for it, it might be at least somewhat relevant.

@Malix-Labs
Copy link
Author

Indeed, the upvote differential is quite significant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or proposal
Projects
None yet
Development

No branches or pull requests

3 participants