Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Théophane Hufschmitt <7226587+thufschmitt@users.noreply.github.com>
  • Loading branch information
Ericson2314 and thufschmitt authored Dec 11, 2023
1 parent 245af3e commit c30b5d8
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/libstore/local-overlay-store.hh
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ struct LocalOverlayStoreConfig : virtual LocalStoreConfig

const PathSetting upperLayer{(StoreConfig*) this, "", "upper-layer",
R"(
Must be used as OverlayFS upper layer for this store's store dir.
Directory containing the OverlayFS upper layer for this store's store dir.
)"};

Setting<bool> checkMount{(StoreConfig*) this, true, "check-mount",
Expand Down Expand Up @@ -60,6 +60,7 @@ struct LocalOverlayStoreConfig : virtual LocalStoreConfig

std::string doc() override;

protected:
/**
* Given a store path, get its location (if it is exists) in the
* upper layer of the overlayfs.
Expand Down Expand Up @@ -167,7 +168,7 @@ private:
* Deduplicate by removing store objects from the upper layer that
* are now in the lower layer.
*
* This implementation will not cause duplications, but addition of
* Operations on a layered store will not cause duplications, but addition of
* new store objects to the lower layer can instill induce them
* (there is no way to prevent that). This cleans up those
* duplications.
Expand Down

0 comments on commit c30b5d8

Please sign in to comment.