forked from trussed-dev/trussed
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Trying to keep track of the UI status before an operation and resetting it afterwards does not work well for us if these operations overlap. Therefore we remove that feature for the time being. This could probably be solved by using counters to keep track of the number of ongoing operations of a certain type.
- Loading branch information
1 parent
269e71a
commit 0994607
Showing
1 changed file
with
1 addition
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0994607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate, on which cases this happens? I would expect that device will just return busy status and deny the request, while processing one already.
AFAIK this was not designed to handle concurrent operations anyway (not to mention limited stack memory).
0994607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not look into the details, but I encountered two scenarios:
process
operations during user confirmation requests on webauthn.bin.coffeeI think in this context, “returning busy” would also be considered “processing”. The alternative would be to just ignore the request and we don’t want to do that. This does not mean that we execute multiple FIDO2 operations in parallel.
0994607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had another look at the logs and the repeated operation is a
RequestUserConsent
request, so this is internal to Trussed and not related to external requests.