Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nk3-change-pin command #45

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add nk3-change-pin command #45

merged 3 commits into from
Dec 9, 2024

Conversation

sosthene-nitrokey
Copy link
Contributor

This PR add the command hotp-verification nk3-change-pin <old-pin> <new-pin> to change the PIN of a NK3.
It only works for NK3.

@nestire
Copy link

nestire commented Nov 27, 2024

for a connected nk pro, nk storage i get this

[user@work nitrokey-hotp-verification (nk3-change-pin)]$ ./hotp_verification nk3-change-pin 123456 111222
HOTP code verification application, version 1.6

Segmentation fault (core dumped)
[user@work nitrokey-hotp-verification (nk3-change-pin)]$

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Please let me know if I should run some tests.

sosthene-nitrokey and others added 3 commits December 9, 2024 10:56
Add support for nitrokey 3 distinction between the secrets app firmware and the device firmware versions
Silently fail if called on an non-nitrokey 3
@sosthene-nitrokey sosthene-nitrokey merged commit 05ac293 into master Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants