Remove static device UUID #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
force-pushed
the
device-uuid
branch
from
fd87d62 to
b9b1b64
Compare
|
No significant changes. Insignifcant changes
|
sosthene-nitrokey
approved these changes
Apr 18, 2024
daringer
approved these changes
Apr 22, 2024
This patch removes the static mut device UUID. This has multiple benefits: It removes some unsafe code, it makes the initialization order explicit and it makes the code compatible with Rust edition 2024.
robin-nitrokey
force-pushed
the
device-uuid
branch
from
b9b1b64 to
22fc4da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the static mut device UUID. This has multiple benefits: It removes some unsafe code, it makes the initialization order explicit and it makes the code compatible with Rust edition 2024.