Webserver PKCS11 Examples #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-nitrokey
approved these changes
Nov 30, 2023
|
Has this feedback been considered? |
mmerklinger
requested changes
Dec 1, 2023
No, the key is still generated locally and upload to the NetHSM. It depends what we want to show with the example. |
|
Yes, I think it would be more natural to generate the key on the NetHSM. |
|
@q-nk Please implement the changes to generate the key on the NetHSM. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 30 30
Lines 6081 6081
=======================================
Hits 5534 5534
Misses 547 547 ☔ View full report in Codecov by Sentry. |
…ly & importing it
q-nk
force-pushed
the
webserver_pkcs11_example
branch
from
0023fec to
d7ad8aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the web server example scripts to the new NetHSM API.