Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZKLLVM_VERSION: unbound variable #34

Closed
Robertorosmaninho opened this issue Jun 27, 2023 · 3 comments · Fixed by #35
Closed

ZKLLVM_VERSION: unbound variable #34

Robertorosmaninho opened this issue Jun 27, 2023 · 3 comments · Fixed by #35
Assignees
@NickVolynkin
Labels
bug Something isn't working

Comments

@Robertorosmaninho
Copy link

Robertorosmaninho commented Jun 27, 2023 •
edited
Loading

Command:

 scripts/ci.sh --docker compile

Log and error message:

+++ dirname -- scripts/ci.sh
++ cd -- scripts
++ pwd
+ SCRIPT_DIR=/Users/robertorosmaninho/rv/zk-experiments/zkllvm-template/scripts
+ REPO_ROOT=/Users/robertorosmaninho/rv/zk-experiments/zkllvm-template/scripts/..
+ command -v podman
+ DOCKER=docker
+ DOCKER_OPTS=
+ USE_DOCKER=false
+ SUBCOMMAND=run_all
+ [[ 2 -gt 0 ]]
+ case $1 in
+ USE_DOCKER=true
+ shift
+ [[ 1 -gt 0 ]]
+ case $1 in
+ SUBCOMMAND=run_all
+ shift
+ [[ 0 -gt 0 ]]
+ echo 'Running run_all'
Running run_all
+ run_all
+ compile
+ '[' true = true ']'
+ cd /Users/robertorosmaninho/rv/zk-experiments/zkllvm-template/scripts/..
++ id -u robertorosmaninho
++ id -g robertorosmaninho
++ pwd
scripts/ci.sh: line 35: ZKLLVM_VERSION: unbound variable

Possible fix:

Add the variable ZKLLVM_VERSION to the ci.sh with the current version!
@Robertorosmaninho
Copy link
Author

Same for TOOLCHAIN_VERSION

@NickVolynkin
Copy link
Contributor

Yep, they're supposed to be set in CI environment, but of course you can run the script without it.

Set the versions before running the script:

export ZKLLVM_VERSION=0.0.58
export TOOLCHAIN_VERSION=0.0.31

NickVolynkin added a commit that referenced this issue Jun 30, 2023
@NickVolynkin
ci.sh: print used image versions and set defaults
8457e38 
Set default versions for two used images:
```
nilfoundation/zkllvm-template
nilfoundation/proof-market-toolchain
```
These versions match ones in ./github/main.yml and should be updated
together.

With defaults, the script can be used without CI environment and
without setting env variables explicitly.

Resolves #34
@NickVolynkin NickVolynkin mentioned this issue Jun 30, 2023
Merged
@NickVolynkin
Copy link
Contributor

Will be fixed in #35

NickVolynkin added a commit that referenced this issue Jun 30, 2023
@NickVolynkin
ci.sh: print used image versions and set defaults
6f5979f 
Set default versions for two used images:
```
nilfoundation/zkllvm-template
nilfoundation/proof-market-toolchain
```
These versions match ones in ./github/main.yml and should be updated
together.

With defaults, the script can be used without CI environment and
without setting env variables explicitly.

Resolves #34
@NickVolynkin NickVolynkin self-assigned this Jul 3, 2023
@NickVolynkin NickVolynkin added the bug Something isn't working label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NickVolynkin NickVolynkin

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci.sh: print used image versions and set defaults NilFoundation/zkllvm-template
2 participants
@NickVolynkin @Robertorosmaninho