Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep lookup constant/selector columns [SyncWith:zkllvm#340] #286

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Keep lookup constant/selector columns [SyncWith:zkllvm#340] #286

merged 1 commit into from
Dec 1, 2023

Conversation

akokoshn
Copy link
Contributor

No description provided.

@akokoshn akokoshn force-pushed the 340-lookup-support-multi-prover branch 11 times, most recently from 38b4c23 to 04562d7 Compare November 23, 2023 06:36
@akokoshn akokoshn requested a review from Iluvmagick November 23, 2023 06:43
Iluvmagick
Iluvmagick requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Iluvmagick Iluvmagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to run the tests with proofs.

include/nil/blueprint/blueprint/plonk/circuit_proxy.hpp Show resolved Hide resolved
include/nil/blueprint/blueprint/plonk/assignment_proxy.hpp Outdated Show resolved Hide resolved
include/nil/blueprint/blueprint/plonk/assignment_proxy.hpp Show resolved Hide resolved
include/nil/blueprint/blueprint/plonk/assignment_proxy.hpp Show resolved Hide resolved
@akokoshn akokoshn force-pushed the 340-lookup-support-multi-prover branch 9 times, most recently from 6f0f090 to 9da1624 Compare November 30, 2023 22:03
@nkaskov nkaskov changed the title Keep lookup constant/selector columns Keep lookup constant/selector columns [SyncWith:zkllvm:#340] Dec 1, 2023
@nkaskov nkaskov changed the title Keep lookup constant/selector columns [SyncWith:zkllvm:#340] Keep lookup constant/selector columns [SyncWith:zkllvm#340] Dec 1, 2023
@nkaskov nkaskov force-pushed the 340-lookup-support-multi-prover branch from 9da1624 to a421f1c Compare December 1, 2023 11:50
@nkaskov nkaskov requested a review from Iluvmagick December 1, 2023 11:57
@nkaskov nkaskov enabled auto-merge (rebase) December 1, 2023 12:01
@nkaskov nkaskov merged commit 168922f into master Dec 1, 2023
42 of 48 checks passed
@Iluvmagick Iluvmagick deleted the 340-lookup-support-multi-prover branch December 1, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iluvmagick Iluvmagick Iluvmagick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akokoshn @Iluvmagick @nkaskov