Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added start_row randomizer to tests. #166

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

Iluvmagick
Copy link
Contributor

Closes #153.
Marked failing/not compiling tests in run_tests.yml -- we need to either create an issue for them/figure out what is wrong, or remove them.

@Iluvmagick Iluvmagick self-assigned this Jul 2, 2023
@Iluvmagick Iluvmagick linked an issue Jul 2, 2023 that may be closed by this pull request
@Iluvmagick
Copy link
Contributor Author

Ideally we would also randomize the public input part -- i.e. shift/rearrange public inputs, but that requires modifying all of the tests.

@Iluvmagick
Copy link
Contributor Author

Currently found that the following tests are broken:

blueprint_algebra_fields_plonk_exponentiation_test
blueprint_algebra_curves_plonk_variable_base_scalar_mul_test
blueprint_algebra_curves_plonk_decomposed_variable_base_scalar_mul_test
blueprint_hashes_plonk_poseidon_test
blueprint_algebra_fields_plonk_non_native_multiplication_test
blueprint_non_native_plonk_scalar_non_native_range_test
blueprint_algebra_fields_plonk_sqrt_test

Removed some others; fixed some which were not passing on my machine.

@Iluvmagick Iluvmagick force-pushed the 153-start-row-index-randomizer branch from af9472c to 1ff1f2b Compare July 3, 2023 15:36
@Luannet Luannet merged commit 5990182 into master Jul 3, 2023
13 of 33 checks passed
@Iluvmagick Iluvmagick deleted the 153-start-row-index-randomizer branch July 25, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add start_row_index randomizer to the test bench.
2 participants