Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable_selector doesn't increase allocated_rows #389

Closed
ETatuzova opened this issue May 30, 2024 · 0 comments
Closed

Enable_selector doesn't increase allocated_rows #389

ETatuzova opened this issue May 30, 2024 · 0 comments
Assignees
@ETatuzova
Labels
bug Something isn't working

Comments

@ETatuzova
Copy link
Contributor

ETatuzova commented May 30, 2024 •
edited
Loading

Satisfiability check runs on blueprint assignment table "allocated_rows":
https://github.com/NilFoundation/zkllvm-blueprint/blob/master/include/nil/blueprint/utils/satisfiability_check.hpp#L63

allocated_rows increases when witnesses or selectors are set, but they are not changed by enable_selector function:
https://github.com/NilFoundation/zkllvm-blueprint/blob/master/include/nil/blueprint/blueprint/plonk/assignment.hpp#L368

So, if selector is switched on some last rows, where witnesses are not allocated, satisfiability check will be passed, but table may not satisfy constraints on these last rows.
@ETatuzova ETatuzova added the bug Something isn't working label May 30, 2024
@ETatuzova ETatuzova changed the title Enable Enable_selector doesn't increase allocated_rows May 30, 2024
@ETatuzova ETatuzova self-assigned this May 30, 2024
ETatuzova added a commit that referenced this issue May 30, 2024
@ETatuzova
Allocated_rows increased according to enable_selector #389
4b6acb8
@ETatuzova ETatuzova linked a pull request May 30, 2024 that will close this issue
389 sat check fix #390
Closed
Iluvmagick pushed a commit that referenced this issue Jun 6, 2024
@ETatuzova @Iluvmagick
Allocated_rows increased according to enable_selector #389
4322e9a
Iluvmagick added a commit that referenced this issue Jun 10, 2024
@Iluvmagick @ETatuzova
Added basic dvm circuit. (#367)
1f43078 
* Added basic zkevm circuit.

* Bytecode circuit constraints added #364 (#375)

Co-authored-by: e.tatuzova <e.tatuzova@nil.foundation>

* Added real opcode numbers assignment.

* Added the new tests to the flake.

* Allocated_rows increased according to enable_selector #389

* Multiprecision changes.

* Updated crypto3 in fix attempt.

* Changed crypto3 to see other tests.

* Fixes for multiprecision update.

* Added missing test.

* Fixed test reporting not running if some tests failed.

* Fixed path in verifier test.

---------

Co-authored-by: e.tatuzova <e.tatuzova@nil.foundation>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ETatuzova ETatuzova

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

389 sat check fix NilFoundation/zkllvm-blueprint
2 participants
@Iluvmagick @ETatuzova