Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depricate currency public methods #17

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

0xAleksaOpacic
Copy link
Collaborator

@0xAleksaOpacic 0xAleksaOpacic commented Sep 24, 2024

Description

This PR deprecates public methods from the Currency contract. Instead, it utilizes nil.js for sending external calls

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Test

@0xAleksaOpacic 0xAleksaOpacic added the enhancement New feature or request label Sep 24, 2024
@0xAleksaOpacic 0xAleksaOpacic self-assigned this Sep 24, 2024
Copy link
Contributor

@Rolaman Rolaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xAleksaOpacic 0xAleksaOpacic merged commit b27b51d into main Sep 24, 2024
2 checks passed
@0xAleksaOpacic 0xAleksaOpacic deleted the improvement/depricate_currency_public_methods branch September 24, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants