Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating structures for aggregated FRI. #329

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

martun
Copy link
Contributor

@martun martun commented Sep 11, 2024

No description provided.

@martun martun self-assigned this Sep 11, 2024
@martun martun linked an issue Sep 11, 2024 that may be closed by this pull request
@martun martun marked this pull request as draft September 11, 2024 07:49
@martun martun force-pushed the 328-add-structures-for-aggregated-fri branch from 1de666d to 9e2e92d Compare September 12, 2024 12:29
};

// Represents a round proof, which must be created just once on the main prover.
struct round_proof_type {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fri_proof_type maybe?

We use round_proof term twice. Once it is a thing that is done by the main prover, and second time is a part of round_proofs_batch_type

It will be easy fri_proof contains

  • fri_round_proof(s)
  • fri_commitments_proof_part

@@ -421,6 +523,60 @@ namespace nil {
eval_storage_type z;
typename basic_fri::proof_type fri_proof;
};

// Represents an initial proof, which must be created for each of the N provers.
struct initial_proof_type {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe lpc_proof_type? Name looks like FRI initial proof.

We run lpc once for each prover and this proof will contain all information that is recieve from one ordinary prover.

  • z
  • initial_fri_proof(s)

}

eval_storage_type z;
typename basic_fri::initial_proofs_batch_type initial_fri_proof;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe initial_fri_proofs? There are many of them

}

// We have a single round proof for checking that F(X) is a low degree polynomial.
typename basic_fri::round_proofs_batch_type fri_round_proof;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fri_round_proofs? Just for clarification. There are many of them.

}

// We have a single round proof for checking that F(X) is a low degree polynomial.
round_proof_type round_proofs;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fri_proof_type fri_proof -- yes, we have only one for all provers

round_proof_type round_proofs;

// For each prover we have an initial proof.
std::vector<initial_proof_type> intial_proofs_per_prover;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::vector<lpc_proof_type> lpc_proofs_per_prover -- vector size is similar to provers amount

@martun martun marked this pull request as ready for review September 13, 2024 13:34
@martun martun force-pushed the 328-add-structures-for-aggregated-fri branch from eceb419 to b1df848 Compare September 13, 2024 13:39
@martun martun force-pushed the 328-add-structures-for-aggregated-fri branch 2 times, most recently from 49ef6ba to 033ecd8 Compare September 14, 2024 09:12
@martun martun force-pushed the 328-add-structures-for-aggregated-fri branch from 033ecd8 to d87d7e7 Compare September 14, 2024 09:16
@martun martun merged commit f8bca3a into master Sep 14, 2024
2 checks passed
@martun martun deleted the 328-add-structures-for-aggregated-fri branch September 14, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add structures for aggregated FRI
2 participants