Remove unused curves #320
Merged
Remove unused curves #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martun
reviewed
Aug 29, 2024
libs/marshalling/algebra/include/nil/crypto3/marshalling/algebra/processing/curve_element.hpp
Show resolved
Hide resolved
martun
approved these changes
Aug 29, 2024
vo-nil
force-pushed
the
319-remove-unused-curves
branch
from
9cd0eae
to
069b3c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused curves:
brainpool family (160..512 bits)
frp_v1
gost_A
NIST curves: p192..p521
x9.62
sm2p_v1
Curves that are to be removed have low (if any) coverage with tests, some have missing parameters and are not used widely in ZK.
The curves that remain are:
mnt4 and mnt6 (298 bits) Security of MNT curves is 77 and 87 bits respectively
bls12-381 and bls12-377
alt_bn128
pallas and vesta
families of secp_k1 and secp_r1 (160..521 bits)
curve25519 and ed25519
jubjub and babyjubjub
closes #319