Tested and Enabled incremental document syncing.

Fixes eclipse-lemminx#133

Removed the incremental setting, it is default and you can't change it

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/XMLLanguageServer.java

@@ -46,7 +46,6 @@
 import org.eclipse.lsp4xml.settings.LogsSettings;
 import org.eclipse.lsp4xml.settings.ServerSettings;
 import org.eclipse.lsp4xml.settings.SharedSettings;
-import org.eclipse.lsp4xml.settings.XMLExperimentalCapabilities;
 import org.eclipse.lsp4xml.settings.XMLFormattingOptions;
 import org.eclipse.lsp4xml.settings.XMLGeneralClientSettings;
 import org.eclipse.lsp4xml.settings.XMLSymbolSettings;
@@ -116,7 +115,7 @@ public void initialized(InitializedParams params) {
 	 * 
 	 * @param initializationOptionsSettings the XML settings
 	 */
-	public void updateSettings(Object initializationOptionsSettings) {
+	public synchronized void updateSettings(Object initializationOptionsSettings) {
 		if (initializationOptionsSettings == null) {
 			return;
 		}
@@ -150,15 +149,6 @@ public void updateSettings(Object initializationOptionsSettings) {
 				String workDir = serverSettings.getNormalizedWorkDir();
 				FilesUtils.setCachePathSetting(workDir);
 			}
-
-			// Experimental capabilities
-			XMLExperimentalCapabilities experimental = xmlClientSettings.getExperimental();
-			if (experimental != null) {
-				boolean incrementalSupport = experimental.getIncrementalSupport() != null
-						&& experimental.getIncrementalSupport().getEnabled() != null
-						&& experimental.getIncrementalSupport().getEnabled().booleanValue();
-				xmlTextDocumentService.setIncrementalSupport(incrementalSupport);
-			}
 		}
 		ContentModelSettings cmSettings = ContentModelSettings.getContentModelXMLSettings(initializationOptionsSettings);
 		if(cmSettings != null) {

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/XMLTextDocumentService.java

@@ -435,7 +435,7 @@ private XMLLanguageService getXMLLanguageService() {
 	}
 
 	public void updateCompletionSettings(CompletionSettings newCompletion) {
-		sharedSettings.completionSettings.setAutoCloseTags(newCompletion.isAutoCloseTags());
+		sharedSettings.setCompletionSettings(newCompletion);
 	}
 
 	public void updateSymbolSettings(XMLSymbolSettings newSettings) {
@@ -454,10 +454,6 @@ public XMLFormattingOptions getSharedFormattingSettings() {
 		return sharedSettings.formattingSettings;
 	}
 
-	public void setIncrementalSupport(boolean incrementalSupport) {
-		this.documents.setIncremental(incrementalSupport);
-	}
-
 	public XMLValidationSettings getValidationSettings() {
 
 		return sharedSettings.validationSettings;

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/commons/TextDocument.java

@@ -139,6 +139,8 @@ public void update(List<TextDocumentContentChangeEvent> changes) {
 			try {
 				synchronized (buffer) {
 					for (TextDocumentContentChangeEvent changeEvent : changes) {
+						ListLineTracker lt = new ListLineTracker();
+						lt.set(buffer.toString());
 
 						Range range = changeEvent.getRange();
 						int length = 0;
@@ -147,17 +149,17 @@ public void update(List<TextDocumentContentChangeEvent> changes) {
 							length = changeEvent.getRangeLength().intValue();
 						} else {
 							// range is optional and if not given, the whole file content is replaced
-							length = getText().length();
-							range = new Range(positionAt(0), positionAt(length));
+							length = buffer.toString().length();
+							range = new Range(lt.getPositionAt(0), lt.getPositionAt(length));
 						}
 						String text = changeEvent.getText();
-						int startOffset = offsetAt(range.getStart());
+						int startOffset = lt.getOffsetAt(range.getStart());
 						buffer.replace(startOffset, startOffset + length, text);
 					}
 					setText(buffer.toString());
 				}
 			} catch (BadLocationException e) {
-				// Should never occurs.
+				// Should never occur.
 			}
 		} else {
 			// like vscode does, get the last changes

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/commons/TextDocuments.java

@@ -26,21 +26,13 @@
  */
 public class TextDocuments implements ITextDocumentFactory {
 
-	private boolean incremental;
+	private final boolean incremental;
 
 	private final Map<String, TextDocument> documents;
 
 	public TextDocuments() {
 		documents = new HashMap<>();
-	}
-
-	/**
-	 * Set the incremental support.
-	 * 
-	 * @param incremental
-	 */
-	public void setIncremental(boolean incremental) {
-		this.incremental = incremental;
+		incremental = true; // Quick fix to set incremental 
 		documents.values().forEach(document -> document.setIncremental(incremental));
 	}
 

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/XMLExperimentalCapabilities.java → org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/XMLExperimentalSettings.java

@@ -14,15 +14,15 @@
  * XML experimental capabilities.
  *
  */
-public class XMLExperimentalCapabilities {
+public class XMLExperimentalSettings {
 
-	private XMLIncrementalSupportCapabilities incrementalSupport;
+	private XMLIncrementalSupportSettings incrementalSupport;
 
-	public void setIncrementalSupport(XMLIncrementalSupportCapabilities incrementalSupport) {
+	public void setIncrementalSupport(XMLIncrementalSupportSettings incrementalSupport) {
 		this.incrementalSupport = incrementalSupport;
 	}
 
-	public XMLIncrementalSupportCapabilities getIncrementalSupport() {
+	public XMLIncrementalSupportSettings getIncrementalSupport() {
 		return incrementalSupport;
 	}
 }

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/XMLGeneralClientSettings.java

@@ -37,8 +37,6 @@ public class XMLGeneralClientSettings {
 	private LogsSettings logs;
 
 	private XMLFormattingOptions format;
-
-	private XMLExperimentalCapabilities experimental;
 
 	private CompletionSettings completion;
 
@@ -69,10 +67,6 @@ public void setFormat(XMLFormattingOptions format) {
 	public XMLFormattingOptions getFormat() {
 		return format;
 	}
-
-	public XMLExperimentalCapabilities getExperimental() {
-		return experimental;
-	}
 
 	/**
 	 * Set completion settings

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/XMLIncrementalSupportCapabilities.java → org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/XMLIncrementalSupportSettings.java

@@ -14,11 +14,14 @@
  * XML experimental incremental support capabilities.
  *
  */
-public class XMLIncrementalSupportCapabilities {
+public class XMLIncrementalSupportSettings {
 
 	private Boolean enabled;
 
 	public Boolean getEnabled() {
+		if(enabled == null) {
+			enabled = true; // default on
+		}
 		return enabled;
 	}
 

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/capabilities/ServerCapabilitiesInitializer.java

@@ -13,7 +13,6 @@
 
 import static org.eclipse.lsp4xml.settings.capabilities.ServerCapabilitiesConstants.DEFAULT_COMPLETION_OPTIONS;
 import static org.eclipse.lsp4xml.settings.capabilities.ServerCapabilitiesConstants.DEFAULT_LINK_OPTIONS;
-import static org.eclipse.lsp4xml.settings.capabilities.ServerCapabilitiesConstants.DEFAULT_SYNC_OPTION;
 
 import org.eclipse.lsp4j.ServerCapabilities;
 import org.eclipse.lsp4j.TextDocumentSyncKind;
@@ -37,9 +36,9 @@ private ServerCapabilitiesInitializer() {
 	public static ServerCapabilities getNonDynamicServerCapabilities(ClientCapabilitiesWrapper clientCapabilities,
 			boolean isIncremental) {
 		ServerCapabilities serverCapabilities = new ServerCapabilities();
-		// @formatter:off
-		serverCapabilities.setTextDocumentSync(DEFAULT_SYNC_OPTION);
+
 		serverCapabilities.setTextDocumentSync(isIncremental ? TextDocumentSyncKind.Incremental : TextDocumentSyncKind.Full);
+
 		serverCapabilities.setDocumentSymbolProvider(!clientCapabilities.isDocumentSymbolDynamicRegistrationSupported());
 		serverCapabilities.setDocumentHighlightProvider(!clientCapabilities.isDocumentHighlightDynamicRegistered());
 		serverCapabilities.setCodeActionProvider(!clientCapabilities.isCodeActionDynamicRegistered());

org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/settings/capabilities/XMLCapabilityManager.java

@@ -145,8 +145,10 @@ public void initializeCapabilities() {
 	}
 
 	/**
-	 * Registers all capabilities that this server can support client side
-	 * preferences to turn on/off
+	 * Registers(indicates the servers ability to support the service) all capabilities that have the ability to be turned
+	 * on/off on the client side through preferences.
+	 * 
+	 * In the case the preference is set to off/false this server will tell the cliet it does not support this capability.
 	 * 
 	 * If a capability is not dynamic, it's handled by
 	 * {@link ServerCapabilitiesInitializer}