Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to readme about dangers of using try-with-resources to autoclose spans #43

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

nicmunroe
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 26, 2017

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #43   +/-   ##
=========================================
  Coverage     98.74%   98.74%           
  Complexity      462      462           
=========================================
  Files            27       27           
  Lines          1115     1115           
  Branches        133      133           
=========================================
  Hits           1101     1101           
  Misses            5        5           
  Partials          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31a50e5...8ca272c. Read the comment docs.

@nicmunroe nicmunroe merged commit df4de07 into Nike-Inc:master Sep 26, 2017
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@nicmunroe
Copy link
Member Author

👍 @adriancole thanks again for pointing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants