TOF interfile and scanner fixes #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
KrisThielemans
commented
Jan 5, 2024
KrisThielemans
commented
- changed "Timing resolution (ps)" keyword to "TOF timing resolution (ps)" (adding previous as an alias)
- better checks and nicer formatting
- removed some test scanners
KrisThielemans
force-pushed
the
TOF_Interfile_scanner_fixes
branch
from
82d22bd to
dbf6a21
Compare
We were still writing "%TOF mashing factor".
KrisThielemans
force-pushed
the
TOF_Interfile_scanner_fixes
branch
from
dbf6a21 to
3931deb
Compare
also add changes to this function to release notes
was "Timing resolution (ps)"
also use new names for the keywords
this isn't currently used for parsing though
KrisThielemans
force-pushed
the
TOF_Interfile_scanner_fixes
branch
from
3931deb to
d7330dc
Compare
|
This should be fine now. Unfortunately, changing the DSTE template to span 2 (it was "0") seems to have uncovered a bug in the scatter estimation, nothing to do with TOF. Initial investigation shows that
estimated (left) and simulated (right) scatter and diff (bottom): |
|
I checked that this happens on As this is independent of this PR, I will revert the change to go back to span=0, rd2 such that we can merge. |
this is a work_around for UCL#1302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.